Clarify various aspects of xmlNamespace traits #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The xmlNamespace trait can only be applied to simple types, list, map, set, structure, union, member, and service shapes. We previously allowed "*", but that includes resource and operation shapes where the trait isn't actually used. * aws.protocols#awsQuery and aws.protocols#ec2Query protocol traits both now require that an xmlNamespace is set on the top-level service shape they are applied to so that the namespace is guaranteed to be known. * Added various examples for how the xmlNamespace trait interacts with flattened lists and maps. * Add a protocol test suite named "restXmlWithNamespace" to test that implementations add an xmlns to restXml services when necessary, closing #616
mtdowling
force-pushed
the
xmlns-details
branch
from
dd9269b
to
930ac23
Compare
kstich
reviewed
Nov 30, 2020
kstich
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map, set, structure, union, and service shapes. We previously
allowed "*", but that includes resource and operation shapes where
the trait isn't actually used.
both now require that an xmlNamespace is set on the top-level
service shape they are applied to so that the namespace is
guaranteed to be known.
with flattened lists and maps.
implementations add an xmlns to restXml services when necessary,
closing Missing protocol test for xmlnamespace-trait applied on service shape #616
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.